Automated cherry pick of #80465: remove apiserver loopback client QPS limit #83142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
area/apiserver
sig/api-machinery
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Justification: Running out of self-request tokens (when checking legacy token authn, and possibly at other times) puts apiserver into a very mysterious priority inversion. |
|
(In theory 1.14+ has made the token auth path not make these requests, but to be consistent with the pick to 1.13, pick it here too. Plus there could be other paths that silently hit this.) |
|
/kind bug |
k8s-ci-robot
added
kind/bug
tpepper
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
liggitt
deleted the
automated-cherry-pick-of-#80465-upstream-release-1.15
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #80465 on release-1.15.
#80465: remove apiserver loopback client QPS limit
For details on the cherry pick process, see the cherry pick requests page.